From 00068ee64a1c24a273f4337eecdf3028ad912a08 Mon Sep 17 00:00:00 2001 From: Carol Willing Date: Wed, 12 Oct 2016 05:18:23 -0700 Subject: [PATCH] Add more precise instructions for OAuth --- README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index e565d91..2108620 100644 --- a/README.md +++ b/README.md @@ -108,12 +108,12 @@ by filling out a form on the GitHub site: In this form, you will specify the OAuth application's callback URL in this format: `https:///hub/oauth_callback`. -After submitting the GitHub form, your registered GitHub OAuth application is -assigned a unique Client ID and Client Secret. The Client Secret should be +After you submit the GitHub form, GitHub registers your OAuth application and +assigns a unique Client ID and Client Secret. The Client Secret should be kept private. -You must pass the GitHub OAuth Client ID, Client Secret and OAuth callback url -to JupyterHub at runtime. You can do this by either: +At JupyterHub's runtime, you must pass the GitHub OAuth Client ID, Client +Secret and OAuth callback url. You can do this by either: - setting the `GITHUB_CLIENT_ID`, `GITHUB_CLIENT_SECRET`, and `OAUTH_CALLBACK_URL` environment variables when you run the